doc: describe using multiple link-module on win #20774
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Current description seems to suggest that only one linked-module can be provided. This modifies the example to show that multiple inked-modules can be used.
nodejs-github-bot
added
build
BUILDING.md
Outdated
| @@ -423,8 +423,9 @@ $ ./configure --link-module '/root/myModule.js' --link-module './myModule2.js' | |||
|
|
|||
| ### Windows | |||
|
|
|||
| To make `./myCustomModule.js` available via `require('myCustomModule')`. | |||
| To make `./myModule.js` available via `require('myModule')` and | |||
| `./myModule2.js` available via `require('myModule2')` | |||
There was a problem hiding this comment.
Maybe a colon at the end?
cjihrig
approved these changes
May 16, 2018
vsemozhetbyt
approved these changes
May 16, 2018
|
Node.js Collaborators, please, add 👍 here if you approve fast-tracking. |
vsemozhetbyt
added
fast-track
trivikr
approved these changes
May 17, 2018
jasnell
approved these changes
May 17, 2018
BridgeAR
approved these changes
May 18, 2018
BridgeAR
pushed a commit
to BridgeAR/node
that referenced
this pull request
May 18, 2018
Current description seems to suggest that only one linked-module can be provided. This modifies the example to show that multiple inked-modules can be used. PR-URL: nodejs#20774 Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Vse Mozhet Byt <[email protected]> Reviewed-By: Trivikram Kamat <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Ruben Bridgewater <[email protected]>
|
Landed in 30ad079 🎉 |
MylesBorins
pushed a commit
that referenced
this pull request
May 22, 2018
Current description seems to suggest that only one linked-module can be provided. This modifies the example to show that multiple inked-modules can be used. PR-URL: #20774 Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Vse Mozhet Byt <[email protected]> Reviewed-By: Trivikram Kamat <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Ruben Bridgewater <[email protected]>
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Current description seems to suggest that only one linked-module can be provided. This modifies the example to show that multiple inked-modules can be used.
Checklist